Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow shouldStartPlayback have the last rebuffer time #2113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow shouldStartPlayback have the last rebuffer time #2113

wants to merge 1 commit into from

Conversation

colinkho
Copy link
Contributor

@colinkho colinkho commented Feb 7, 2025 •
edited
Loading

  • Add lastRebufferRealtimeMs to LoadControl.Parameters

@marcbaechinger
Copy link
Contributor

Thanks @colinkho for your PR!

I'm going to send this for internal review. Please ignore the comment around inline comments in the test class. I'm going to fix this myself and will push this to the PR once done.

@colinkho
Copy link
Contributor Author

colinkho commented Feb 16, 2025 •
edited
Loading

Hi, any update on the PR here? @marcbaechinger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcbaechinger marcbaechinger marcbaechinger left review comments

@icbaker icbaker icbaker left review comments

Assignees

@marcbaechinger marcbaechinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colinkho @marcbaechinger @icbaker