Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration cache should just work for internally run CI scripts #630

Open
wants to merge 1 commit into
base: androidx-main
Choose a base branch
from

Conversation

kaeawc
Copy link

@kaeawc kaeawc commented Nov 16, 2023

For context, I talked with @liutikas about this change. While configuration cache doesn't yet have a good way of working on non-ephemeral hosts, it should be fine as long as the internal CI is preserving the cc-keystore directory in Gradle user home and other fingerprinted Gradle dependency/script caches.

Proposed Changes

  • Remove the --no-configuration-cache flag on internal busytown CI scripts.

Testing

Test: None

@yigit
Copy link
Collaborator

yigit commented Nov 16, 2023

last time i tried this, it failed with some test tasks. I just tried running a test locally with configuration cache and link tasks are still tripping it:

image
Am I missing something?

@yigit
Copy link
Collaborator

yigit commented Nov 16, 2023

btw this is the command i run

ANDROIDX_PROJECTS=INFRAROGUE ./gradlew :sqliteMultiplatform:sqlite-driver-unbundled:allTests :sqliteMultiplatform:sqlite-driver-unbundled:cC

@kaeawc
Copy link
Author

kaeawc commented Nov 16, 2023

Ah darn. I'll take a look at those, thanks for the local repro instructions.

@kaeawc
Copy link
Author

kaeawc commented Nov 16, 2023

Getting a lot of configuration issues referencing prebuilts unfortunately, so I can't get to that error:

* What went wrong:
Could not resolve all files for configuration 'classpath'.
> Could not find com.google.protobuf:protobuf-java:3.22.3.
  Required by:
      unspecified:unspecified:unspecified
> Could not find com.squareup.okio:okio:3.3.0.
  Required by:
      unspecified:unspecified:unspecified
> Could not find com.gradle:gradle-enterprise-gradle-plugin:3.14.1.
  Required by:
      unspecified:unspecified:unspecified
> Could not find com.gradle:common-custom-user-data-gradle-plugin:1.11.1.
  Required by:
      unspecified:unspecified:unspecified
> Could not find androidx.build.gradle.gcpbuildcache:gcpbuildcache:1.0.0-beta05.
  Required by:
      unspecified:unspecified:unspecified

I'll see if I can find some workarounds for that module's Task.project usages.

@yigit
Copy link
Collaborator

yigit commented Nov 16, 2023

oh, you need the full repo checkout to run that project. Since you sent these CI changes, i thought you had that already.
We don't compile that project on github right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants