fix - remove width property of bottomSheet modifier #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Short description
I want the fillMaxWidth() property applied to the Surface that constitutes the BottomSheetScaffold's sheetContent to be removed.
Long description
The reason is because I want to always show the width of the sheetContent as the width of the content, not the fillMaxWidth in landscape mode.
Currently, to set the width of the sheetContent to a specific dp value in landscape mode, the width of the BottomSheetScaffold itself must be adjusted.
However, in this case, if the UI of the app shows a map such as Google Map, there is an issue that the touch event is not delivered well.
I guess many apps don't want the width of the bottomSheet to always be full in landscape mode.
The ui layer of our app in landscape mode looks like this: (카카오맵 = Map such as Google Map)
Testing
Test:
I copied all the BottomSheetScaffold codes and modified only the parts I wanted to test.
The result was successful!
To create the CustomBottomSheetScaffold I also had to copy the Swipeable because of the line of code below.
Issues Fixed
Fixes: