Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat the source to use Unix line breaks always #448

Open
wants to merge 2 commits into
base: androidx-main
Choose a base branch
from
Open

Reformat the source to use Unix line breaks always #448

wants to merge 2 commits into from

Conversation

adaext
Copy link
Contributor

@adaext adaext commented Sep 10, 2022

  • Source file had line breaks mixed in Windows format and Unix format.
  • Reformat the file using dos2unix command.

Test: ./gradlew test connectedCheck

@alanv
Copy link
Member

alanv commented Sep 19, 2022

I'll revert the original change from Gerrit, then re-apply it with correct line breaks. Otherwise the file history gets all messed up.

@alanv alanv closed this Sep 19, 2022
@alanv alanv reopened this Sep 19, 2022
@alanv
Copy link
Member

alanv commented Sep 19, 2022

Given that you were the only author, this should be fine to take instead of a revert.

@alanv alanv self-assigned this Sep 19, 2022
@adaext
Copy link
Contributor Author

adaext commented Sep 20, 2022

Given that you were the only author, this should be fine to take instead of a revert.

Ok, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanv alanv alanv approved these changes

Assignees

@alanv alanv

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@adaext @alanv