Fix emptyResultIsReturned_withNotMatchingQuery unit test
#1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonMarquis
force-pushed
the
fix-unit-test
branch
from
1dff04f to
8ffc24e
Compare
|
@thagikura gentle ping since you introduced this |
|
LGTM. Thanks for doing this! But since I no longer work at Google, please have someone from Google look at it. @dturner FYI |
dturner
approved these changes
Dec 22, 2023
|
Hi @SimonMarquis and @dturner, can you please review this PR and merge it? Would be nice to have these changes available into |
`searchResultUiState` transitively relied on `getSearchContentsCount` updates and on `userDataRepository` to emit something.
SimonMarquis
force-pushed
the
fix-unit-test
branch
from
f866eb0 to
5a12582
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
searchResultUiStatetransitively relied ongetSearchContentsCountupdates and onuserDataRepositoryto emit something.