Fix issue with pulling standings

createpercentiles.py

@@ -0,0 +1,25 @@
+import pandas as pd
+import pickle
+import json
+from satchel.constants import TEAM_ABBRS
+from collections import defaultdict
+
+
+def create_percentiles():
+    # Load the data
+    with open("2024projections/openingday2024.p", "rb") as f:
+        results = pickle.load(f)
+    percentiles = {}
+    for team in TEAM_ABBRS:
+        _percentiles = {}
+        for i in range(1, 163):
+            _percentiles[i] = results.season_percentile(team, i)
+        percentiles[team] = _percentiles
+
+    # save percentiles as a json
+    with open("2024projections/percentiles.json", "w") as f:
+        json.dump(percentiles, f, sort_keys=True, indent=4)
+
+
+if __name__ == "__main__":
+    create_percentiles()

satchel/__init__.py

@@ -1,3 +1,3 @@
-from satchel import constants, model, modelresults, plotting
+from satchel import constants, model, modelresults, plotting, standings
 from satchel.modelcomparison import SatchelComparison
 from satchel.schedules.createschedule import create_schedule

satchel/model.py

@@ -12,12 +12,14 @@
 from .schedules.cache.clear_cache import clear_cache as clear_schedule_cache
 from .modelresults import SatchelResults
 from .schedules.createschedule import create_schedule, OPENING_DAY, YEAR, FINAL_DAY
+from .standings import standings
 from collections import Counter
 from pathlib import Path, PosixPath
 from typing import Union
 from tqdm import tqdm
 from datetime import datetime
-from pybaseball import standings
+
+# from pybaseball import standings
 from io import StringIO
 from typing import Union
 

satchel/standings.py

@@ -0,0 +1,120 @@
+"""
+This is the standings module used in pybaseball. I'm temporarily copying it
+to deal with a bug in the package. Will be removed once the package is updated.
+"""
+
+from typing import List, Optional
+
+import pandas as pd
+from bs4 import BeautifulSoup, Comment, PageElement, ResultSet
+
+from pybaseball.cache import cache
+from pybaseball.utils import most_recent_season
+from pybaseball.datasources.bref import BRefSession
+
+session = BRefSession()
+
+
+def get_soup(year: int) -> BeautifulSoup:
+    url = f"https://www.baseball-reference.com/leagues/MLB/{year}-standings.shtml"
+    s = session.get(url).content
+    return BeautifulSoup(s, "lxml")
+
+
+def get_tables(soup: BeautifulSoup, season: int) -> List[pd.DataFrame]:
+    datasets = []
+    if season >= 1969:
+        tables: List[PageElement] = soup.find_all("table")
+        if season == 1981:
+            # For some reason BRef has 1981 broken down by halves and overall
+            # https://www.baseball-reference.com/leagues/MLB/1981-standings.shtml
+            tables = [x for x in tables if "overall" in x.get("id", "")]
+        for table in tables:
+            data = []
+            headings: List[PageElement] = [
+                th.get_text() for th in table.find("tr").find_all("th")
+            ]
+            data.append(headings)
+            table_body: PageElement = table.find("tbody")
+            rows: List[PageElement] = table_body.find_all("tr")
+            for row in rows:
+                cols: List[PageElement] = row.find_all("td")
+                cols_text: List[str] = [ele.text.strip() for ele in cols]
+                cols_text.insert(0, row.find_all("a")[0].text.strip())  # team name
+                data.append([ele for ele in cols_text if ele])
+            datasets.append(data)
+    else:
+        data = []
+        table = soup.find("table")
+        headings = [th.get_text() for th in table.find("tr").find_all("th")]
+        headings[0] = "Name"
+        if season >= 1930:
+            for _ in range(15):
+                headings.pop()
+        elif season >= 1876:
+            for _ in range(14):
+                headings.pop()
+        else:
+            for _ in range(16):
+                headings.pop()
+        data.append(headings)
+        table_body = table.find("tbody")
+        rows = table_body.find_all("tr")
+        for row in rows:
+            if row.find_all("a") == []:
+                continue
+            cols = row.find_all("td")
+            if season >= 1930:
+                for _ in range(15):
+                    cols.pop()
+            elif season >= 1876:
+                for _ in range(14):
+                    cols.pop()
+            else:
+                for _ in range(16):
+                    cols.pop()
+            cols = [ele.text.strip() for ele in cols]
+            cols.insert(0, row.find_all("a")[0].text.strip())  # team name
+            data.append([ele for ele in cols if ele])
+        datasets.append(data)
+    # convert list-of-lists to dataframes
+    for idx in range(len(datasets)):
+        datasets[idx] = pd.DataFrame(datasets[idx])
+    return datasets  # returns a list of dataframes
+
+
+@cache.df_cache()
+def standings(season: Optional[int] = None) -> pd.DataFrame:
+    """
+    Returns a pandas DataFrame of the standings for a given MLB season, or the most recent standings
+    if the date is not specified.
+
+    ARGUMENTS
+        season (int): the year of the season
+    """
+    # get most recent standings if date not specified
+    if season is None:
+        season = most_recent_season()
+    if season < 1876:
+        raise ValueError(
+            "This query currently only returns standings until the 1876 season. "
+            "Try looking at years from 1876 to present."
+        )
+
+    # retrieve html from baseball reference
+    soup = get_soup(season)
+    if season >= 1969:
+        raw_tables = get_tables(soup, season)
+    else:
+        t = [
+            x
+            for x in soup.find_all(string=lambda text: isinstance(text, Comment))
+            if "expanded_standings_overall" in x
+        ]
+        code = BeautifulSoup(t[0], "lxml")
+        raw_tables = get_tables(code, season)
+    tables = [pd.DataFrame(table) for table in raw_tables]
+    for idx in range(len(tables)):
+        tables[idx] = tables[idx].rename(columns=tables[idx].iloc[0])
+        tables[idx] = tables[idx].reindex(tables[idx].index.drop(0))
+    return tables