Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

Added scrollbars to token list and enabled scrollbar fading #804 #812

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ullas-Aithal
Copy link
Contributor

No description provided.

@flocke flocke self-assigned this Apr 24, 2021
@flocke flocke added this to In progress in UX Design / Theme via automation Apr 24, 2021
@flocke flocke added this to the v0.9.1 milestone Apr 24, 2021
@ziegenberg
Copy link
Contributor

Looks good to me. Does what it claims to do.

I would suggest just one small change. In my opinion, the android:scrollbarStyle should be set to outsideOverlay. It serves as a position indicator and is not intrusive. I believe the other options do not look as good). See below for a comparison.

@flocke what do you think?

scrollbar_outsideOverlay

outsideInset:
makes the margin of the entry cards not equally wide

scrollbar_outsideInset

insideOverlay:
makes the scroll bar appear on top of the entry cards

scrollbar_insideOverlay

insideInset:
makes the margin of the entry cards not equally wide and sticks the scroll bar right up to the entry cards, leaving a wide gap to the border of the screen. that's the worst of all options.

scrollbar_insideInset

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants