Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-640: Check that PGDATA and postgres mountPoint are in alignmen… #414

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gnyahay
Copy link
Contributor

@gnyahay gnyahay commented Oct 24, 2024

Check that PGDATA and postgres mountPoint are in alignment if configured

@gnyahay gnyahay requested a review from a team as a code owner October 24, 2024 19:34
@gnyahay gnyahay force-pushed the gn/feature/DEVOPS-640-validate-pgdata-and-mountpoint branch from 238d091 to a4f9b72 Compare October 25, 2024 13:57
@gnyahay gnyahay force-pushed the gn/feature/DEVOPS-640-validate-pgdata-and-mountpoint branch from a4f9b72 to 32fc20a Compare October 25, 2024 14:05
@Btodhunter
Copy link
Member

@gnyahay Thanks for the PR! This is a great thing to validate. I wonder if this would be better suited for the upstream Bitnami postgresql chart though? It would fit in pretty well right here - https://github.com/bitnami/charts/blob/main/bitnami/postgresql/templates/_helpers.tpl#L320

@gnyahay
Copy link
Contributor Author

gnyahay commented Oct 31, 2024

@gnyahay Thanks for the PR! This is a great thing to validate. I wonder if this would be better suited for the upstream Bitnami postgresql chart though? It would fit in pretty well right here - https://github.com/bitnami/charts/blob/main/bitnami/postgresql/templates/_helpers.tpl#L320

I thought about that. If the variable for the data directory was based off the variable for the mount point in the upstream chart then this wouldn't even be needed. They may have their reasons for setting the values independently and so my thought was that this validation is specific to the use case of their chart in our chart and therefore it makes sense to go into our chart.

If I put it in their chart I would probably need to include the same logic for replicas as well, not just primary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants