Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP CI tool: shipmonk/composer-dependency-analyser #1572

Merged

Conversation

janedbal
Copy link
Contributor

@mre
Copy link
Member

mre commented Apr 16, 2024

We haven't had emojis in the description before, and I don't know how I feel about it, but let's give it a shot. There's a chance that we'll remove them if they cause any issues. Just a heads-up. 😉

@mre mre merged commit f667ae5 into analysis-tools-dev:master Apr 16, 2024
2 checks passed
@mre
Copy link
Member

mre commented Apr 16, 2024

Thanks for the addition, @janedbal. ⭐

@janedbal
Copy link
Contributor Author

When can I expect this tool to show in https://analysis-tools.dev/ so that I can check the emojis?

@mre
Copy link
Member

mre commented Apr 16, 2024

Noticed that we didn't take changes to the tools.json file into account, which gets rendered whenever we add a new tool and which serves as the "API" for the website.
I've prepared a fix here: analysis-tools-dev/website-next#74
Once this gets merged, I hope that the changes will be reflected immediately (well, after a few minutes at least) after adding a new tool.🤞

@mre
Copy link
Member

mre commented Apr 16, 2024

Should be live when this turns green: https://github.com/analysis-tools-dev/website-next/actions/runs/8704215487

@mre
Copy link
Member

mre commented Apr 16, 2024

It's up, but it's not pretty:
https://analysis-tools.dev/tool/composer-dependency-analyser

The reason is that I forgot to pay attention to the YAML formatting instructions.
This should fix it: https://github.com/analysis-tools-dev/static-analysis/blob/master/data/tools/composer-dependency-analyser.yml

On the plus side, we can test the automatic deployment with that, so it should be fixed in a few minutes.

@mre
Copy link
Member

mre commented Apr 16, 2024

Okay, worked like a charm. It's pretty now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants