Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update api routes #940

Merged
merged 3 commits into from Mar 30, 2024
Merged

Conversation

pi0
Copy link

@pi0 pi0 commented Mar 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Small updates for API route bast practices.

@pi0 pi0 changed the title docs/api route update docs: update api routes Mar 14, 2024
@pi0 pi0 changed the base branch from beta to main March 14, 2024 21:39
Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 1f75be1
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/660430691133800008038bbf
😎 Deploy Preview https://deploy-preview-940--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 1f75be1
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/660430696a295d00087c56d9
😎 Deploy Preview https://deploy-preview-940--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 1f75be1
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/66043068a5acc000084a63cc
😎 Deploy Preview https://deploy-preview-940--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 1f75be1
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/66043069f4d07e0008ff3551
😎 Deploy Preview https://deploy-preview-940--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pi0 pi0 marked this pull request as ready for review March 27, 2024 14:42
@brandonroberts brandonroberts merged commit b03dfb3 into analogjs:main Mar 30, 2024
24 checks passed
@brandonroberts
Copy link
Member

Thanks! @allcontributors add @pi0 for doc

Copy link
Contributor

@brandonroberts

I've put up a pull request to add @pi0! 🎉

@pi0 pi0 deleted the docs/api-route-update branch March 30, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants