-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CMSIS): Adding mallinfo function and reworking Cordio memory management. #1179
Conversation
Need to call this multiple times to allow us to calculate the size requirements before requesting the heap memory.
This is a significant API change. We need to call WsfHeapAlloc with the required size before calling WsfHeapGetFreeStartAddress. This will allow us to do dynamic memory allocation, instead of allocating a large block of memory on initialization.
@crsz20 I was just thinking, it would be good to add a LL function for the size calculation. We're copying a lot of code that could be consolidated. |
Which part do you think could be consolidated? In the |
…solved hard-fault error.
Lines 127 - 133 in the file below. We could add a function with the same parameters as LlInit() that returns the memory requirement. |
/clang-format-run |
Found a bug in the in BLE4_ctr example on ME17 that seems to date back to the following commit:
The BLE_datc and some other examples seem to run fine, however. I back-traced the error to I am not sure how this may be dependent on the recent changes to the heap memory management. |
Yes it sounds unrelated. I'm not sure why it would only fail on this example. That same procedure is done in most of the examples to get the Bluetooth address. Can you step through the procedure to see how it's failing? We've seen this before on pre-production parts where the USN isn't programmed properly. This would be a chip specific error that we would always see, not a software error. |
Seems to be failing at the checksum verification. |
This is a common problem with the pre-production parts. Please try a different board to see if we have the same problem. |
The USN bug seems to be unrelated and is being resolved in a separate PR. Will proceed to update the rest of the examples. |
/clang-format-run |
/clang-format-run |
In BLE demos, is it necessary to add a CMD to display the contents of struct mallinfo? |
No, I don't think so. The memory management is handled behind the scenes. |
Description
Adding mallinfo function to give us information on how much heap space is being used and how much is available. Reworking the Cordio memory management so we don't have to request an arbitrarily large block of memory on initialization.
Checklist Before Requesting Review