Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PeriphDrivers): MAX32690 Only Reset ADC, TMR, UART if Clock is not Locked #1153

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

Jake-Carter
Copy link
Contributor

Description

Closes CFSIO-2300

Only issue a full reset to ADC, TMR, & UART if the clock source has not already been previously locked. Otherwise CFS's clock config will be clobbered.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@Jake-Carter Jake-Carter changed the title MAX32690: Only reset ADC, TMR, UART if Clock is not Locked fix(PeriphDrivers): MAX32690 Only Reset ADC, TMR, UART if Clock is not Locked Sep 4, 2024
@github-actions github-actions bot added the MAX32690 Related to the MAX32690 (ME18) label Sep 4, 2024
@sihyung-maxim
Copy link
Contributor

Not sure why the Hash example is failing with this PR...unless it's been breaking previously. The Hash example mainly uses the CTB and TRNG, but the ISO does need to be enabled for the CTB.

@Jake-Carter
Copy link
Contributor Author

Not sure why the Hash example is failing with this PR...unless it's been breaking previously. The Hash example mainly uses the CTB and TRNG, but the ISO does need to be enabled for the CTB.

Not sure either... this doesn't touch anything related. Will merge it for now and see if it propagates through

@Jake-Carter Jake-Carter merged commit 03dd1b1 into analogdevicesinc:main Sep 4, 2024
7 of 8 checks passed
@Jake-Carter Jake-Carter deleted the fix/CFSIO-2300 branch September 4, 2024 22:38
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 4, 2024
ozersa pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 11, 2024
ozersa pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAX32690 Related to the MAX32690 (ME18)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants