fix(PeriphDrivers): MXC_SYS_GetUSN Checksum error #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
MAX32655
|
/clang-format-run |
sihyung-maxim
approved these changes
Jun 24, 2024
|
|
||
| /* Read the checksum from the info block */ | ||
| /* Read the checksum from the inspfo block */ |
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
For some MCUs, the
MXC_SYS_GetUSNfunction used the AES peripheral to calculate the checksum.#1016 Addresses an issue with the possibility of an unbounded memory access. The
MXC_SYS_GetUSNfunction now only copies and clears the 13 bytes of the USN. However, the checksum is calculated using the USN checksum length not the USN length, so the CRC was calculated using the correct 13 bytes of the USN plus 3 uninitialized bytes causing checksum errors. This patch fixes this issue.