Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PeriphDrivers): Fix MXC_SYS_GetUSN Buffer Overflow #1016

Merged
merged 2 commits into from
Jun 18, 2024
Merged

fix(PeriphDrivers): Fix MXC_SYS_GetUSN Buffer Overflow #1016

merged 2 commits into from
Jun 18, 2024

Conversation

Jake-Carter
Copy link
Contributor

Description

Fixes #1006

This PR updates MXC_SYS_GetUSN to prevent buffer overflow. The application-side buffer should be MXC_SYS_USN_LEN, but we were using MXC_SYS_USN_CHECKSUM_LEN which is a larger buffer size with some additional padding used for the internal CRC calculation.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added MAX32655 Related to the MAX32655 (ME17) MAX32665 Related to the MAX32665 (ME14) MAX32670 Related to the MAX32670 (ME15) MAX32672 Related to the MAX32672 (ME21) MAX32675 Related to the MAX32675 (ME16) MAX32680 Related to the MAX32680 (ME20) MAX32690 Related to the MAX32690 (ME18) MAX32662 Related to the MAX32662 (ME12) labels May 13, 2024
@github-actions github-actions bot added MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87) labels May 13, 2024
@EricB-ADI
Copy link
Contributor

Can we get this reviewed and merge this in?

@Jake-Carter
Copy link
Contributor Author

Can we get this reviewed and merge this in?

Yep, ready for review

@Jake-Carter Jake-Carter merged commit 74a552e into analogdevicesinc:main Jun 18, 2024
8 of 9 checks passed
@Jake-Carter Jake-Carter deleted the fix/gh-1006 branch June 18, 2024 22:52
EricB-ADI pushed a commit that referenced this pull request Jun 20, 2024
@Jake-Carter @EricB-ADI
fix(PeriphDrivers): Fix MXC_SYS_GetUSN Buffer Overflow (#1016)
c478504
@EricB-ADI EricB-ADI mentioned this pull request Jun 20, 2024
Merged
EricB-ADI pushed a commit that referenced this pull request Jun 24, 2024
@Jake-Carter @EricB-ADI
fix(PeriphDrivers): Fix MXC_SYS_GetUSN Buffer Overflow (#1016)
acde79a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricB-ADI EricB-ADI EricB-ADI approved these changes

@sihyung-maxim sihyung-maxim Awaiting requested review from sihyung-maxim

Assignees
No one assigned
Labels
MAX32655 Related to the MAX32655 (ME17) MAX32662 Related to the MAX32662 (ME12) MAX32665 Related to the MAX32665 (ME14) MAX32670 Related to the MAX32670 (ME15) MAX32672 Related to the MAX32672 (ME21) MAX32675 Related to the MAX32675 (ME16) MAX32680 Related to the MAX32680 (ME20) MAX32690 Related to the MAX32690 (ME18) MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buffer overflow in MXC_SYS_GetUSN / sys_me15.c
2 participants
@Jake-Carter @EricB-ADI