Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump most packages and improved Impression attributes to use standard Python bool #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
cycler==0.11.0
fonttools==4.33.1
joblib==1.2.0
kiwisolver==1.4.2
llvmlite==0.38.0
matplotlib==3.5.1
numba==0.55.1
numpy==1.22.0
packaging==21.3
pandas==1.3.5
Pillow==10.0.1
pyparsing==3.0.8
cycler==0.12.1
fonttools==4.45.0
joblib==1.3.2
kiwisolver==1.4.5
llvmlite==0.41.1
matplotlib==3.8.2
numba==0.58.1
numpy==1.26.2
packaging==23.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase? I have updated package versions

pandas==2.1.3
Pillow==10.1.0
pyparsing==3.1.1
python-dateutil==2.8.2
pytz==2022.1
scikit-learn==1.0.2
scipy==1.10.0
seaborn==0.11.2
pytz==2023.3.post1
scikit-learn==1.3.2
scipy==1.11.4
seaborn==0.13.0
six==1.16.0
threadpoolctl==3.1.0
torch==1.13.1
tqdm==4.64.0
typing_extensions==4.2.0
threadpoolctl==3.2.0
torch==2.1.1
tqdm==4.66.1
typing_extensions==4.8.0
4 changes: 2 additions & 2 deletions src/Impression.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ class ImpressionOpportunity:
estimated_CTR: np.float32
price: np.float32
second_price: np.float32
outcome: np.bool
won: np.bool
outcome: bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the existing np.bool creating any issues for you?

won: bool

def set_true_CTR(self, best_expected_value, true_CTR):
self.best_expected_value = best_expected_value # Best possible CTR (to compute regret from ad allocation)
Expand Down