Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arepo (do not merge) #925

Draft
wants to merge 74 commits into
base: main
Choose a base branch
from
Draft

Arepo (do not merge) #925

wants to merge 74 commits into from

Conversation

rieder
Copy link
Member

@rieder rieder commented Feb 2, 2023

PR to add Arepo (WIP, do not merge!)

mtwest2718 and others added 27 commits May 23, 2022 08:56
Add basic arepo test.

Co-authored-by: Steven Rieder <[email protected]>
…mum used timestep sizes increases during a step, it could happen that for particles on the maximum timestep one gravity half-step is not applied (because HighestActiveTimeBin increases)
Three of four recent commits from arepo on gitlab
(https://gitlab.mpcdf.mpg.de/vrs/arepo).

Documentation update omitted since arepo documentation has been removed
here.
Preparing to run the Arepo example `isolated_galaxy_collusionless_3d`.
Arepo flags (in `arepo/src/Makefile`) sourced from
`arepo/run/examples/myexample/Config.sh`.

Co-authored-by: thomasguillet <[email protected]>
May want to remove from child makefile to avoid duplication.

Co-authored-by: Steven Rieder <[email protected]>
Add Arepo flag "Multiple restarts" (effect not fully tested).

Co-authored-by: Steven Rieder <[email protected]>
Modify test parameters.

Co-authored-by: Steven Rieder <[email protected]>
Avoid HDF5 - we will use AMUSE to extract data instead of snapshotting.
The multiple restarts flag keeps more than one restart file for unreliable
systems.
Re-add initialization code to test script.
Include naive find_particle_with_ID to be optimized later.

Co-authored-by: Thomas Guillet <[email protected]>
Currently with a naive search for particle ID.
Using `size_t` for the output position ID, but this is defined in Arepo
as an unsigned int.
Based on test_simple.py.
Removed call to missing `write_compile_time_options_in_hdf5` function in
`src/io/io.c`.  In Arepo this function is written to a file by a perl
script at compile time.
Also fill in gravitational acceleration getter.
This breaks the former "collisionless galaxy 3D" example, since the
Arepo compiler flags are hard-coded into the Makefiles.

Once the ICs file has been copied from the Arepo source (as outlined in
ICs.placeholder) the new python script `test_noh3d.py` runs the example
and saves figures of the output at t = 0.1, 1.0 and 1.9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants