Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #501 #768

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix #501 #768

wants to merge 1 commit into from

Conversation

chaseleif
Copy link

Issue was caused when using RGB mask and requesting RGBA output.
Arrays had differing dimensions (mask did not have alpha).
Duplicate a channel and append it to the contour, this allows the subsequent math operations.

Followed instructions in CONTRIBUTING.md, flake8 and pytest.
flake8 reports 2 lines in wordcloud_cli.py (that I did not touch)
pytest passes all 76 collected items

Copy link

@kitsukoe kitsukoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix does exactly what it says it does. It fixes the problem of contours not working in RGBA mode, and doesn't look like it will break anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants