Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❄️ Skip flaky e2e test amp-subscriptions-google #39915

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

powerivq
Copy link
Contributor

@powerivq powerivq commented Mar 21, 2024

#39914

This is now blocking a few PRs from being merged.

Copy link

Hey @jpettitt! These files were changed:

extensions/amp-subscriptions-google/0.1/test-e2e/test-amp-subscriptions-google.js

@danielrozenberg
Copy link
Member

license/cla isn't picking up this PR correctly (happens often when you commit a comment suggestion, my bad) - I'll force-merge this now since we know this is fine

@danielrozenberg danielrozenberg merged commit 3f8ad6d into ampproject:main Mar 21, 2024
50 checks passed
@powerivq powerivq deleted the suppress-d branch March 21, 2024 18:19
TribooAnalytics pushed a commit to TribooAnalytics/amphtml that referenced this pull request Apr 3, 2024
* Skip flaky e2e test amp-subscriptions-google

* Update extensions/amp-subscriptions-google/0.1/test-e2e/test-amp-subscriptions-google.js

Co-authored-by: Daniel Rozenberg <[email protected]>

---------

Co-authored-by: Daniel Rozenberg <[email protected]>
eszponder pushed a commit to krzysztofequativ/amphtml that referenced this pull request Apr 22, 2024
* Skip flaky e2e test amp-subscriptions-google

* Update extensions/amp-subscriptions-google/0.1/test-e2e/test-amp-subscriptions-google.js

Co-authored-by: Daniel Rozenberg <[email protected]>

---------

Co-authored-by: Daniel Rozenberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants