-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add locking to File interface #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trowski
changed the title
Add lock and unlock to File interface
Add locking to File interface
Dec 8, 2024
kelunik
reviewed
Dec 8, 2024
No need to protect against large values of 2 ** $attempt.
Updated to also add |
kelunik
reviewed
Dec 13, 2024
This was referenced Jan 12, 2025
Closed
This was referenced Jan 12, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three new methods to the
File
interface:lock
,unlock
, andgetLockMode
. As the names imply, these functions provide a non-blocking method obtaining and releasing a shared or exclusive lock on the file. The mode is provided by a new enum,LockMode
with two cases:Shared
andExclusive
.lock
tries to obtain the lock in a loop using an exponential-backoff until a lock is obtained or the optional cancellation is cancelled.getLockMode
returns the current lock mode if the file has been locked or null otherwise.I've refactored
FileMutex
andKeyedFileMutex
to use these two new async methods.I think is a better option than #86, however it will require a new major version since the
File
interface has been modified. I don't consider this a blocker, as most components will be able to require 3.x or 4.x.DO NOT merge into
3.x
, we'll need make a4.x
branch if this is merged.