Adds ADX support

[scottdyer]

Adds support for reading and writing ADX compliant DPX files from ctlrender.

[scottdyer]

@miaoqi , I am having issues writing ADX files after your latest changes, though at one point earlier in the commit chain it seemed to be writing files just fine.

I'm now getting a "Floating point exception: 8" error.

Here are some variants of commands I tried:

ctlrender -ctl ACESlib.Unity.a1.0.1.ctl SonyF35.StillLife.exr test.dpx -format adx10

ctlrender -ctl ACESlib.Unity.a1.0.1.ctl SonyF35.StillLife.exr test.dpx -format adx16

ctlrender -ctl ACESlib.Unity.a1.0.1.ctl SonyF35.StillLife.exr test.dpx -format adx

Input is a 16-bit OpenEXR.

I am trying to get output of either ADX10 or ADX16. I would expect it to work similarly to using -format dpx or -format dpx10 or -format dpx16

Is there anything in particular that you changed in commit range 1d0535f to 47fb2d0 that might be causing this exception?

[miaoqi]

When I cleaned up the code after previous commit, this error occurred once. Let me look into it.

Thanks,

Mio

[miaoqi]

Hi Scott,

The float point issue should be fixed now. The problem is probably caused by float16_t to uint8_t conversion.

Now when it comes to use “SonyF35.StillLife.exr”, it may not be good for converting to adx, as it breaks a few adx spec. For example, the descriptor for the first element is 221 or something like that, while adx just expects 50/RGB for the first element and 4/alpha for the second one. I temporarily changed “Error” to “Warning” in the output so you can test it.

Thanks,

Mio

[Δ]http://www.oscars.org

Miaoqi Zhu
Lab Systems Administrator

Academy of Motion Picture Arts and Sciences
Science & Technology Council
1313 Vine Street • Hollywood, CA 90028

310.247.3000 x3302 • [email protected]:[email protected]

From: Scott Dyer <[email protected]mailto:[email protected]>
Reply-To: ampas/CTL <[email protected]mailto:[email protected]>
Date: Monday, November 9, 2015 at 1:51 PM
To: ampas/CTL <[email protected]mailto:[email protected]>
Cc: Miaoqi Zhu <[email protected]mailto:[email protected]>
Subject: Re: [CTL] Adds ADX support (#61)

@miaoqihttps://github.com/miaoqi , I am having issues writing ADX files after your latest changes, though at one point earlier in the commit chain it seemed to be writing files just fine.

I'm now getting a "Floating point exception: 8" error.

Here are some variants of commands I tried:

ctlrender -ctl ACESlib.Unity.a1.0.1.ctl SonyF35.StillLife.exr test.dpx -format adx10

ctlrender -ctl ACESlib.Unity.a1.0.1.ctl SonyF35.StillLife.exr test.dpx -format adx16

ctlrender -ctl ACESlib.Unity.a1.0.1.ctl SonyF35.StillLife.exr test.dpx -format adx

Input is a 16-bit OpenEXR.

I am trying to get output of either ADX10 or ADX16. I would expect it to work similarly to using -format dpx or -format dpx10 or -format dpx16

Is there anything in particular that you changed in commit range 1d0535fhttps://github.com/ampas/CTL/commit/1d0535fee27cb80bc2cf6495383de12ff9483236 to 47fb2d047fb2d0 that might be causing this exception?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/61#issuecomment-154515864.

[miaoqi]

Hi Scott,

Does the fix work for your transform? Please be aware that "adx" is same as "adx10". You also have "adx16".

Thanks,

Mio

[miaoqi]

Hi Scott,

Can you use the latest code and let me know if the temporary fix address the issue? :)

Thanks,

Mio