Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitchen sink build (including externals) #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mojodna
Copy link
Contributor

@mojodna mojodna commented Dec 22, 2015

This is the true kitchen sink build that includes all of the requisite dependencies.

@ericsoco
Copy link
Member

What's your overall strategy @mojodna? One "kitchen sink" build and...something else?

Ideally, we have a build that only brings in the dependencies of the imported components. Not sure how possible that is, but I see you addressing that in other PRs. Might be good for you, I, and @sconnelley to pow-wow on where we're trying to take this (after we're back in the "office").

@mojodna
Copy link
Contributor Author

mojodna commented Jan 12, 2016

No real strategy, more soliciting feedback (successfully!).

If I understand you elsewhere (#12), the component "build" should only consist of a babel step and not do anything to make them consumable in forms other than npm-facilitated require(). If so, this shouldn't be merged (as webpack would be removed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants