Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require python>=3.9 #48

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

require python>=3.9 #48

wants to merge 4 commits into from

Conversation

juanep97
Copy link

The syntax in tests/test_bitrot.py

StdOut = list[str]
StdErr = list[str]

was implemented in 3.9 for the first time.

@ambv
Copy link
Owner

ambv commented Aug 24, 2023

How about instead we just put those lines in a if TYPE_CHECKING: block?

@ambv
Copy link
Owner

ambv commented Aug 24, 2023

Then we can keep 3.8 compatibility.

@juanep97
Copy link
Author

juanep97 commented Aug 31, 2023

I agree. In addition:

  • Added in .gitignore some python compiling and distribution related files.
  • Fixed setuptools_scm usage in the .toml file.

Fixing setuptools_scm was necessary to avoid this error when installing with pip install -e .:

          return meta(
        File ".../site-packages/setuptools_scm/version.py", line 226, in meta
          parsed_version = _parse_tag(tag, preformatted, config)
        File ".../site-packages/setuptools_scm/version.py", line 203, in _parse_tag
          assert version is not None
      AssertionError
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build editable did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

@juanep97 juanep97 closed this Sep 24, 2023
@juanep97 juanep97 reopened this Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants