Skip to content

[BUG] Bad escaping for a string with \$ sequence #593 #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

[BUG] Bad escaping for a string with \$ sequence #593 #594

wants to merge 1 commit into from

Conversation

Ph0enixKM
Copy link
Member

@Ph0enixKM Ph0enixKM commented Nov 14, 2024 •
edited
Loading

This fixes #593 and relies on #592 so until it's not merged, the pipeline will fail.

Blocked by #592

@Ph0enixKM Ph0enixKM linked an issue Nov 14, 2024 that may be closed by this pull request
[BUG] Bad escaping for a string with \$ sequence #593
Open
@Ph0enixKM Ph0enixKM added bug Something isn't working compiler labels Nov 14, 2024
@Ph0enixKM Ph0enixKM added this to the Amber 0.4.0-alpha milestone Nov 14, 2024
@lens0021 lens0021 mentioned this pull request Nov 16, 2024
Merged
@Ph0enixKM Ph0enixKM added the pr/stalled This PR is blocked by other PR label Dec 18, 2024
@Ph0enixKM Ph0enixKM changed the base branch from master to staging December 19, 2024 11:13
@Ph0enixKM Ph0enixKM self-assigned this Dec 20, 2024
@Mte90
Copy link
Member

Mte90 commented Apr 10, 2025

@Ph0enixKM requires an update this PR

@ArjixWasTaken
Copy link

Btw, you can add Blocked by #592 to the description so it is properly marked by GitHub.

@Ph0enixKM
Copy link
Member Author

I've updated the description.
@ArjixWasTaken where does GitHub mark this PR as blocked?

@Mte90 Mte90 requested review from Mte90 and hdwalters and removed request for Mte90 April 16, 2025 10:39
@Mte90
Copy link
Member

Mte90 commented Apr 16, 2025

Right now doesn't fail, something that got fixed in the meantime?
It is still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdwalters hdwalters Awaiting requested review from hdwalters

@Mte90 Mte90 Awaiting requested review from Mte90

At least 2 approving reviews are required to merge this pull request.

Assignees

@Ph0enixKM Ph0enixKM

Labels
bug Something isn't working compiler pr/stalled This PR is blocked by other PR
Projects
None yet
Milestone
Amber 0.5.0-alpha
Development

Successfully merging this pull request may close these issues.

[BUG] Bad escaping for a string with \$ sequence
3 participants
@Ph0enixKM @Mte90 @ArjixWasTaken