Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle case where the locale param is an array and set cookie expiration to one year #435

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

amannn
Copy link
Owner

@amannn amannn commented Aug 1, 2023

Changes:

  • Handle case where the locale param is an array
  • Set cookie expiration to one year
  • Pin Next.js version in examples
  • Use latest tag in examples (for CSB)

Fixes #431

@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
example-next-13-next-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 10:29am
next-intl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 10:29am
next-intl-example-next-13 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 10:29am

@amannn amannn changed the title fix: Handle case where the locale param is an array fix: Handle case where the locale param is an array and add set cookie expiration to one year Aug 1, 2023
@amannn amannn marked this pull request as ready for review August 1, 2023 08:43
@amannn amannn changed the title fix: Handle case where the locale param is an array and add set cookie expiration to one year fix: Handle case where the locale param is an array and set cookie expiration to one year Aug 1, 2023
@aXenDeveloper
Copy link

Hi 👋
I see you're pinned version for next, but do you have plan to upgrade next to the latest version?
For me not-found.tsx file not working from 13.4.10+ version of next.

@amannn
Copy link
Owner Author

amannn commented Aug 1, 2023

Thanks for chiming in @aXenDeveloper!

Eventually, I'd definitely like to upgrade to the latest version, but I've been bitten quite a few times by now with subtle bugs that were introduced in Next.js patch versions.

The latest being:

It takes quite some time to diagnose these issues and to participate in the upstream discussions. Some of these issues will be ironed out anyway again on the Next.js side, therefore I think it might be reasonable to stay a few patch versions behind on a release that is known to be stable.

@amannn amannn merged commit 82e842c into main Aug 1, 2023
6 checks passed
@amannn amannn deleted the chore/upgrade-next branch August 1, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep locale after session was closed
2 participants