-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(RSC): Clean up package boundaries #387
Merged
amannn
merged 26 commits into
feat/next-13-rsc
from
feat/next-13-rsc-clean-up-package-boundaries
Jul 26, 2023
Merged
refactor(RSC): Clean up package boundaries #387
amannn
merged 26 commits into
feat/next-13-rsc
from
feat/next-13-rsc-clean-up-package-boundaries
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-boundaries # Conflicts: # pnpm-lock.yaml
…-13-rsc-clean-up-package-boundaries
…-13-rsc-clean-up-package-boundaries # Conflicts: # packages/next-intl/package.json # packages/use-intl/package.json # pnpm-lock.yaml
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…-13-rsc-clean-up-package-boundaries # Conflicts: # packages/next-intl/src/react-server/getBaseTranslator.tsx # packages/next-intl/src/react-server/useTranslations.tsx # packages/next-intl/src/server/getTranslations.tsx # packages/next-intl/src/server/getTranslator.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
exports
touse-intl
to have clear package boundaries and add new APIscore
:RichTranslationValuesPlain
,createBaseTranslator
,initializeConfig
, TS utilsreact
: (no changes)exports
tonext-intl
Information
We build the entry point and nested exports from libraries separately because the build for the main entry point is always smaller this way. Nested exports always result in separate modules currently.