Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redirect to put gmail redirect into account #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eloquentcoder
Copy link

Here are some of the proposed changes I would suggest be implemented

  • Updated all occurrences of http to https in EmailChecker.php
  • Update the 301 redirect inside the checkdomain function to also include a check for 302 redirect and return true is the domain redirected is gmail as gmail.com gets redirected to mail.google.com

@aman00323
Copy link
Owner

Thanks for contributing @patdgeerico. I have few queries

  • Why static gmail.com? if we can go with another option by getting a redirect URL.
  • `HTTP was there to ensure if some email server is using that protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants