set version at build time (#142)

amalshaji · Mar 2, 2025 · b1de0f9 · b1de0f9
1 parent 2128695
commit b1de0f9
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 6 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -95,3 +95,5 @@ jobs:
             linux/amd64
             linux/arm64
           file: ${{ matrix.dockerfile }}
+          build-args: |
+            VERSION=${{ github.ref_name }}
diff --git a/.goreleaser.yaml b/.goreleaser.yaml
@@ -13,7 +13,7 @@ builds:
       - amd64
       - arm64
     ldflags:
-      - -s -w -X main.build={{.Version}}
+      - -s -w -X main.version={{.Version}}
 
 archives:
   - format: zip

diff --git a/tunnel/Dockerfile b/tunnel/Dockerfile
@@ -8,7 +8,9 @@ RUN go mod download
 
 COPY . /app/
 
-RUN CGO_ENABLED=1 go build -ldflags="-s -w -linkmode external -extldflags \"-static\"" -o portrd ./cmd/portrd
+ARG VERSION=dev
+
+RUN CGO_ENABLED=1 go build -ldflags="-s -w -linkmode external -extldflags \"-static\" -X main.version=${VERSION}" -o portrd ./cmd/portrd
 
 FROM alpine:3.20 AS final
 

diff --git a/tunnel/cmd/portr/main.go b/tunnel/cmd/portr/main.go
@@ -10,13 +10,14 @@ import (
 	"github.com/urfave/cli/v2"
 )
 
-const VERSION = "0.0.29-beta"
+// Set at build time
+var version = "0.0.0"
 
 func main() {
 	app := &cli.App{
 		Name:    "portr",
 		Usage:   "Expose local ports to the public internet",
-		Version: VERSION,
+		Version: version,
 		Flags: []cli.Flag{
 			&cli.StringFlag{
 				Name:    "config",

diff --git a/tunnel/cmd/portrd/main.go b/tunnel/cmd/portrd/main.go
@@ -16,13 +16,14 @@ import (
 	"github.com/urfave/cli/v2"
 )
 
-const VERSION = "0.0.29-beta"
+// Set at build time
+var version = "0.0.0"
 
 func main() {
 	app := &cli.App{
 		Name:    "portrd",
 		Usage:   "portr server",
-		Version: VERSION,
+		Version: version,
 		Commands: []*cli.Command{
 			{
 				Name:  "start",