Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to subscription-url-dialog.component #1922

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Add tests to subscription-url-dialog.component #1922

merged 1 commit into from
Jun 6, 2022

Conversation

adam-osu
Copy link
Contributor

@adam-osu adam-osu commented Jun 4, 2022 •
edited

Fixes

Part of #1717

Checks

  • Ran yarn test-build
  • Updated relevant documentations
  • Updated matching config options in altair-static

Changes proposed in this pull request:

This PR adds tests around the functionality of the subscription-url-dialog.component:

  • handleEditorRefresh gets called on change detection
  • subscriptionUrlChange
  • updateSubscriptionProviderId

@adam-osu
Add tests to subscription-url-dialog.component
5f2a2ca 
Change test for handleEditorRefresh call on change detection check
@adam-osu
Copy link
Contributor Author

adam-osu commented Jun 6, 2022

Thanks for the review @imolorhe! I've rebased with the chrome update which I think should fix the ubuntu e2e tests

@imolorhe imolorhe merged commit f1fa70f into altair-graphql:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imolorhe imolorhe imolorhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adam-osu @imolorhe