Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features to distill template #2840

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

ShuhongDai
Copy link
Contributor

@ShuhongDai ShuhongDai commented Nov 13, 2024

While using the distill template, I noticed it lacked many features available in the regular post template, such as typograms, echarts, and other interactive elements. To address this, I included the necessary scripts and dependencies for these features in distill.liquid, referencing them from misc.liquid. Now, the distill template offers the same interactive functionality as the post template.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for relaxed-lollipop-b6bc17 ready!

Name Link
🔨 Latest commit 3b9b491
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-lollipop-b6bc17/deploys/675052115152d600082f656a
😎 Deploy Preview https://deploy-preview-2840--relaxed-lollipop-b6bc17.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@george-gca
Copy link
Collaborator

Have you tested this? Also, can you create maybe a new distill post with all these included in it, so we can demonstrate how to use and how they'll appear?

@ShuhongDai
Copy link
Contributor Author

Have you tested this? Also, can you create maybe a new distill post with all these included in it, so we can demonstrate how to use and how they'll appear?

Regarding the Distill post, I can create a new post that includes the changes and demonstrates how they can be used. I'll start working on it and share the draft with you soon.😀

@ShuhongDai
Copy link
Contributor Author

  1. After testing, I verified that currently only the scripts {% include scripts/badges.liquid %} and {% include scripts/pseudocode.liquid %} cannot be used in Distill. Therefore, I removed these two lines of code from distill.liquid.

  2. The other scripts have been validated successfully. I updated 2018-12-22-distill.md and added a tutorial in the blog on how to use these scripts.

@george-gca
Copy link
Collaborator

Just missing prettier complaints and it will be merged.

@ShuhongDai
Copy link
Contributor Author

I have reviewed the code and fixed the prettier issues.

package-lock.json Outdated Show resolved Hide resolved
@george-gca
Copy link
Collaborator

Just missing the prettier complaints.

@ShuhongDai
Copy link
Contributor Author

Just missing the prettier complaints.

Locally, Prettier confirms all files are correctly formatted, and the version I pushed passed Prettier checks on my machine. However, the GitHub Action still reports a Prettier failure.

截屏2024-12-04 12 47 28

@george-gca
Copy link
Collaborator

This error was already fixed in the main branch. Just rebase your branch with main and it should fix this.

@ShuhongDai ShuhongDai force-pushed the add-new-features-for-distill branch from 8674057 to 3b9b491 Compare December 4, 2024 12:58
@george-gca
Copy link
Collaborator

Thanks for your contribution.

@george-gca george-gca merged commit 957dc2c into alshedivat:main Dec 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants