Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign property to group headers to make them disappear when filterin… #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dassburger
Copy link

Bug fixes for empty group header hiding when filtering agenda view:

  • Assign org-super-agenda-header property to the group header and the newline before it, so that when filtering agenda view, both the header and it's newline are hidden too. (org-super-agenda--hide-or-show-groups expects that property).
  • Assign org-super-agenda-header property to the new line before the group header, so that calendar view does not have extra newlines inside it when filtering.
  • Preserve agenda block separators when hiding groups.

…g, hide group header's newline in calendar, preserve agenda block separators when hiding group headers.
@AndreaOrru
Copy link

Any chance this will be merged?

@alphapapa
Copy link
Owner

alphapapa commented Feb 7, 2023

@AndreaOrru Probably, I just have to find time to review it carefully, since the diff is rather large (though largely indentation due to the enclosing let, it seems). Feel free to test it and report back. :)

@alphapapa alphapapa added this to the 1.4 milestone Sep 24, 2023
Copy link
Owner

@alphapapa alphapapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience. Please see this suggested change.

Comment on lines +1239 to +1242
(agenda-block-separator-p ()
(let ((current-line (buffer-substring (point-at-bol) (point-at-eol))))
(or (string= current-line agenda-block-separator)
(string= current-line ""))))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible to use looking-at-p for this test, which would save consing a string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants