Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Make auto-outline-path separator customizable #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

braun-steven
Copy link

Thanks for your recent addition of outline-path based grouping.

I propose to make the outline-path separator customizable since the default "/" makes the group name too dense in my view.

@alphapapa alphapapa self-assigned this Nov 20, 2020
@alphapapa alphapapa added this to the 1.3 milestone Nov 20, 2020
Copy link
Owner

@alphapapa alphapapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience.

@@ -172,7 +172,7 @@ Every selector requires an argument, even if it's just ~t~, e.g. ~:anything~, ~:
+ ~:auto-dir-name~ :: This automatically groups items by the directory name of their source buffer.
+ =:auto-group= :: This selects items that have the =agenda-group= Org property set. By setting this property for a subtree, every item in it will be sorted into an agenda group by that name and placed into the agenda where the ~:auto-group~ selector is ([[examples.org#automatically-by-group][example]]).
+ ~:auto-map~ :: This automatically groups items by the value returned when applying each item to the given function as a string from the agenda buffer ([[examples.org#automatically-by-mapping-a-function][example]]). The function should return a string to be used as the grouping key and as the header for its group.
+ =:auto-outline-path= :: This automatically groups items by their outline path hierarchy, like =Plans/Take over the universe/Take over the moon=.
+ =:auto-outline-path= :: This automatically groups items by their outline path hierarchy, like =Plans/Take over the universe/Take over the moon=. The outline path separator is defined by =org-super-agenda-auto-outline-path-separator= (default is "/").
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Two spaces between sentences, please.

@@ -980,9 +980,10 @@ of the arguments to the function."
(directory-name (->> file-path file-name-directory directory-file-name file-name-nondirectory)))
(concat "Directory: " directory-name)))

(setq org-super-agenda-auto-outline-path-separator "/")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a defcustom.

@alphapapa alphapapa modified the milestones: 1.3, 1.4 Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants