Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending org-ql-open-link #384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

fgiasson
Copy link

@fgiasson fgiasson commented Dec 7, 2023

Extending org-ql-open-link to be able to search across multiple Org files from the agenda or a directory containing Org files (optionally recursively using org-ql-search-directories-files-recursive to true).

Those two new additions are based on org-ql-find-in-agenda. This enables to use org-ql-open-link but on multiple files from the Org agenda file or a specific directory.

This is very helpful for someone that has a lot of Org/ROAM files with a lot of external links to be able to use its Org knowledge base as a place where bookmarks exists (better contextualized than a series of bookmarks in a browser).

Extending org-ql-open-link to be able to search across multiple Org files from
the agenda or a directory containing Org files (optionally recursively using
org-ql-search-directories-files-recursive to true).
@alphapapa
Copy link
Owner

Hello Frederick,

Thanks, this seems like a good idea. However, before adding two more similar commands, I'd like to think about whether an alternative scheme might be more useful (i.e. the paradigm of doing X at each matching entry, where X in this case is collecting a link and later choosing one to open). I don't know what else we might end up making an org-ql-find-type command for, other than opening the entry or opening links, but it's something to consider.

Also, as I'd like to keep open the possibility of adding Org QL to Org itself or to GNU ELPA, have you signed the FSF copyright assignment for Emacs, or would you be willing to?

Thanks.

@alphapapa alphapapa self-assigned this Dec 9, 2023
@alphapapa alphapapa added this to the Future milestone Dec 9, 2023
@fgiasson
Copy link
Author

Thanks, this seems like a good idea. However, before adding two more similar commands, I'd like to think about whether an alternative scheme might be more useful (i.e. the paradigm of doing X at each matching entry, where X in this case is collecting a link and later choosing one to open). I don't know what else we might end up making an org-ql-find-type command for, other than opening the entry or opening links, but it's something to consider.

This is good thinking. It could pretty much be any Org element. But then the question becomes: what else is actionable like links? There are multitude of ways to search within a Org file, so in this case I am not sure it is more about searching than searching and performing an action on what is found (in that case, opening a web link).

I don't have anything specific on mind, but I will think about that some more.

Also, as I'd like to keep open the possibility of adding Org QL to Org itself or to GNU ELPA, have you signed the FSF copyright assignment for Emacs, or would you be willing to?

I don't remember if I did or not, but sure I can sign it.

@alphapapa
Copy link
Owner

Thanks, this seems like a good idea. However, before adding two more similar commands, I'd like to think about whether an alternative scheme might be more useful (i.e. the paradigm of doing X at each matching entry, where X in this case is collecting a link and later choosing one to open). I don't know what else we might end up making an org-ql-find-type command for, other than opening the entry or opening links, but it's something to consider.

This is good thinking. It could pretty much be any Org element. But then the question becomes: what else is actionable like links? There are multitude of ways to search within a Org file, so in this case I am not sure it is more about searching than searching and performing an action on what is found (in that case, opening a web link).

I don't have anything specific on mind, but I will think about that some more.

Sounds good.

Also, as I'd like to keep open the possibility of adding Org QL to Org itself or to GNU ELPA, have you signed the FSF copyright assignment for Emacs, or would you be willing to?

I don't remember if I did or not, but sure I can sign it.

Ok, please let me know when you have done so.

@fgiasson
Copy link
Author

Waiting for the forms and how to finalize the process. Will circle back here once this is done. Sorry for the delay

@alphapapa
Copy link
Owner

No problem, there's no urgency here. Thanks.

@fgiasson
Copy link
Author

@alphapapa ok, I just sent them the signed copy. Do you need something else (maybe from them?)

@alphapapa
Copy link
Owner

@alphapapa ok, I just sent them the signed copy. Do you need something else (maybe from them?)

AFAIK we need to wait for them to send you a final confirmation. Only the Emacs maintainers have access to the list of assignees. Maybe you could email the secretary and ask them to send me a confirmation as well, so then I'd know when we're clear to merge your code.

@fgiasson
Copy link
Author

Yeah, still waiting for the final signature on their end. Will ping them again if I don't get anything this week thanks

@fgiasson
Copy link
Author

@alphapapa I just received it, where should I send it?

@alphapapa
Copy link
Owner

@alphapapa I just received it, where should I send it?

I've since found out that I need to get confirmation from either the FSF secretary or the Emacs maintainers. So you could email the secretary and ask them to email me the confirmation, or forward what you have to me, and then I can ask the Emacs maintainers to confirm it to me. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants