add predicate for checking DONE state changes #245
Conversation
| @@ -60,6 +60,11 @@ | |||
| Like `org-clock-line-re', but matches the timestamp range in a | |||
| match group.") | |||
|
|
|||
| (defconst org-ql-log-done-regexp | |||
| (rx bol "- State \"DONE\"" (1+ blank) "from \"WAITING\"" (1+ blank) (group (1+ not-newline))) | |||
| ;; TODO: Remove hardcoded states, i.e DONE & WAITING | |||
There was a problem hiding this comment.
This todo should be fixed before merging. So the regexp, rather than matching DONE from WAITING, should probably match an arbitrary state from an arbitrary state, so the predicate could work like (logbook-state "DONE") or (logbook-state "DONE" "WAITING").
There was a problem hiding this comment.
Can you help me with this @alphapapa ?
I've tried adding these arguments to the predicate, but don't know how to change the preambles and normalizers part.
There was a problem hiding this comment.
Those are pcase forms. Pcase isn't the easiest tool to learn, but it's very powerful. I'll take a look at this when I get time, but that may not be for a while, so don't be afraid to dive in to Pcase's documentation in the meantime.
| @@ -60,6 +60,11 @@ | |||
| Like `org-clock-line-re', but matches the timestamp range in a | |||
| match group.") | |||
|
|
|||
| (defconst org-ql-log-done-regexp | |||
| (rx bol "- State \"DONE\"" (1+ blank) "from \"WAITING\"" (1+ blank) (group (1+ not-newline))) | |||
There was a problem hiding this comment.
I think logbooks always use the - character as their bullet character, but we should make sure of that before merging.
| @@ -1969,6 +1974,24 @@ ignored." | |||
| :body | |||
| (org-ql--predicate-ts :from from :to to :regexp org-ql-clock-regexp :match-group 1)) | |||
|
|
|||
| (org-ql-defpred log-done (&key from to _on) | |||
There was a problem hiding this comment.
The predicate should probably be named something like logbook-state so it could be more flexible.
|
Also please note that this feature will need tests and documentation before being merged. |
alphapapa
force-pushed
the
master
branch
2 times, most recently
from
4f5fbc4
to
d0acc8c
Compare
alphapapa
force-pushed
the
master
branch
2 times, most recently
from
059b10c
to
77b4c2b
Compare
This PR fixes issue #192
Apart from the regex, every other added code is almost copied/pasted.
Further improvements are welcome