Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ivy-org-ql work #201

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make ivy-org-ql work #201

wants to merge 3 commits into from

Conversation

dsdshcym
Copy link
Contributor

Hi @alphapapa,
thanks for your work on org-ql

I made some changes to your wip/ivy branch and made ivy-org-ql function work

A hack (a13a930) is required due to abo-abo/swiper#2677
(Not sure if using text-property is the best way here)

alphapapa and others added 3 commits March 24, 2021 09:30
@alphapapa @dsdshcym
WIP: ivy support
31ceb80
@dsdshcym
use org-ql--query-string-to-sexp instead of org-ql--plain-query
168e3e0 
- latter was deprecated
@dsdshcym
extract ivy-org-ql--heading-cons to make ivy-org-ql work
a13a930 
- ivy doesn't support calling action function with a cons when dynamic-collection is on
  see abo-abo/swiper#2677
  so we had to use text-property to store (point-marker)
@alphapapa
Copy link
Owner

Hi,

Thanks for updating this. I've been busy lately, but when I have time, I'll look at this more closely and test it. I'll try to get to the issues and PRs on my repos generally in the order they were sent. Thanks for your patience.

@alphapapa alphapapa self-assigned this Mar 31, 2021
@alphapapa alphapapa added this to the 0.6 milestone Jun 8, 2021
@alphapapa
Copy link
Owner

As I just posted on #63, rather than supporting Ivy directly, it might be better to make some commands that use the completing-read API so they could work with various completion frontends. What do you think?

@alphapapa alphapapa modified the milestones: 0.6, Future Jun 17, 2021
@dsdshcym
Copy link
Contributor Author

Yes, that would be the best! (I just tried selectrum recently, lol)

Though I don't know how to make org-ql work with completing-read, especially how to make it async.
So I'm closing this PR for now.
Looking forward to the 0.6 release. 🚀

@alphapapa
Copy link
Owner

I'm also not sure if completing-read will work, since it's not really a matter of "completing" strings. Let's leave this PR open for now, until we're sure it won't be necessary.

@alphapapa alphapapa force-pushed the master branch 2 times, most recently from 4f5fbc4 to d0acc8c Compare May 30, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alphapapa alphapapa

Labels
enhancement
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsdshcym @alphapapa