Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style fixes #43

Closed
wants to merge 4 commits into from
Closed

Style fixes #43

wants to merge 4 commits into from

Conversation

eczy-tempus
Copy link

While working on #42 I noticed a number of linter complaints that presumably began appearing after the recent bump to go1.18. This PR fixes these, most commonly:

  • Error messages starting with capital letters
  • Redundant type definitions that are inferred by enclosing collection definitions
  • a nil context

This also moves all integration test files into the _test scope.

@eczy-tempus
Copy link
Author

Bump. Just resolved the merge conflicts that resulted from changes in master since I opened this PR.

@eczy-tempus
Copy link
Author

Closing because this is old and went unaddressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant