-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build(deps): bump validates_timeliness and rails #1578
base: main
Are you sure you want to change the base?
Conversation
Follow these steps if you are doing a Rails upgrade. |
4b45cb5
to
19dcf9c
Compare
We need to upgrade the app to rails 8. |
0b1f678
to
0c506ad
Compare
4d995f1
to
5c2824e
Compare
e692669
to
2244cd9
Compare
Bumps [validates_timeliness](https://github.com/adzap/validates_timeliness) and [rails](https://github.com/rails/rails). These dependencies needed to be updated together. Updates `validates_timeliness` from 7.1.0 to 8.0.0 - [Changelog](https://github.com/adzap/validates_timeliness/blob/master/CHANGELOG.md) - [Commits](adzap/validates_timeliness@v7.1.0...v8.0.0) Updates `rails` from 7.2.2.1 to 8.0.1 - [Release notes](https://github.com/rails/rails/releases) - [Commits](rails/rails@v7.2.2.1...v8.0.1) --- updated-dependencies: - dependency-name: validates_timeliness dependency-type: direct:production update-type: version-update:semver-major - dependency-name: rails dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
2244cd9
to
1f1b33e
Compare
@@ -22,7 +22,7 @@ gem "select2-rails" | |||
gem "sentry-sidekiq" | |||
gem "sprockets-rails" | |||
gem "terser" | |||
gem "validates_timeliness", "~> 7.1.0" | |||
gem "validates_timeliness", "~> 8.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO (by whoever works on this Rails upgrade): look into why this gem was pinned to a specific version.
If there's no obvious reason, we should remove the version constraint from the Gemfile.
Bumps validates_timeliness and rails. These dependencies needed to be updated together.
Updates
validates_timeliness
from 7.1.0 to 8.0.0Changelog
Sourced from validates_timeliness's changelog.
... (truncated)
Commits
3c6d2fa
v8.0.0bf3dcb9
chore: freeze RESERVED_OPTIONS282e676
chore: remove old gemfilesc3c4459
feat: pass non-reserved validation options to errors665b3da
v8.0.0.beta184b86a8
chore: setting up for Rails 8 releaseUpdates
rails
from 7.2.2.1 to 8.0.1Release notes
Sourced from rails's releases.
... (truncated)
Commits
cf6ff17
Preparing for 8.0.1 release0bba3c2
Merge pull request #53936 from jsharpify/jsharpify/prism-parsing8521b99
[RF-DOCS] Update Rails Testing Guide [ci skip] (#53872)dbe61a7
Merge pull request #53907 from p8/guides/fix-canonicalf8d559d
[RF-DOCS] Asset Pipeline Documentation (Propshaft) [ci-skip] (#53875)2ae1d69
[RF-DOCS] Solid Cache updates in Caching with Rails: An Overview [ci-skip] (...85bde83
Merge pull request #53926 from Ridhwana/Ridhwana/solid-queuec167cbe
Merge pull request #53941 from byroot/rack-server-protocol656e209
Merge pull request #53940 from mjankowski/rdoc-link-to-add-check-constraintb9608a6
Merge pull request #53937 from fatkodima/mysql-fix-remove-foreign-key-restrictYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)