Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Temporarily add content request fields into the ticket body" #1201

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Revert "Temporarily add content request fields into the ticket body" #1201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions app/models/zendesk/ticket/content_change_request_ticket.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,20 +28,6 @@ def custom_fields

def comment_snippets
snippets = [
Zendesk::LabelledSnippet.new(
on: @request,
field: :reason_for_change,
label: "Reason for request",
),
Zendesk::LabelledSnippet.new(
on: @request,
field: :subject_area,
label: "Subject area",
),
Zendesk::LabelledSnippet.new(on: self, field: :needed_by_date, label: "Deadline date"),
Zendesk::LabelledSnippet.new(on: self, field: :needed_by_time, label: "Deadline time"),
Zendesk::LabelledSnippet.new(on: self, field: :not_before_date, label: "Do not publish before date"),
Zendesk::LabelledSnippet.new(on: self, field: :not_before_time, label: "Do not publish before time"),
Zendesk::LabelledSnippet.new(
on: @request,
field: :url,
Expand Down
20 changes: 1 addition & 19 deletions spec/features/content_change_requests_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,25 +20,7 @@
"tags" => %w[govt_form content_amend],
"comment" => {
"body" =>
"[Reason for request]
Factual inaccuracy

[Subject area]
Benefits

[Deadline date]
31-12-#{next_year}

[Deadline time]
13:00

[Do not publish before date]
01-12-#{next_year}

[Do not publish before time]
18:00

[URLs to be changed]
"[URLs to be changed]
http://gov.uk/X

[Details of what should be added, amended or removed]
Expand Down