Test updates for explanatory helpers #4566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theseanything
approved these changes
Jun 11, 2020
These files no longer need the .govspeak.erb extension and are renamed to .erb. This change is done to reflect that these files contain a mixture of govspeak and text.
These extensions are no longer necessary as the file can be resolved without them.
This takes the places where we are rendering govspeak in test fixtures using render_content_for and changes them to the more explicit govspeak_for method.
kevindew
force-pushed
the
test-updates-for-explanatory-helpers
branch
from
7dcc953 to
09d11b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #4527 this applies the new smart answer helpers, the filename conventions and more conventional partial includes to the test fixtures.
I've applied this only to the test fixtures so this isn't too scary a thing to review