Add a check for departmental_editor? permission for user #2517
+68
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baisa
force-pushed
the
add-additional-dept-permission-layer
branch
from
e4606a5 to
8dd95db
Compare
baisa
force-pushed
the
add-additional-dept-permission-layer
branch
4 times, most recently
from
506bb63 to
eb72797
Compare
ellohez
approved these changes
Feb 10, 2025
| def departmental_editor? | ||
| permissions.include?("departmental_editor") | ||
| end | ||
|
|
There was a problem hiding this comment.
Just wondering, does this have an effect on the before actions that exist in Publisher? I have seen some that currently only check has_editor_permissions?
mtaylorgds
reviewed
Feb 11, 2025
baisa
force-pushed
the
add-additional-dept-permission-layer
branch
3 times, most recently
from
a0fb99a to
b0b6e5e
Compare
mtaylorgds
reviewed
Feb 13, 2025
This is to enable specifying restriction to access Mainstream content by departments. It is an addition to giving access by matching owning_org_content_ids with users organisation_content_id, to ensure we do not block access for some departments.
baisa
force-pushed
the
add-additional-dept-permission-layer
branch
from
b0b6e5e to
de87ab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
This is to enable specifying restriction to access Mainstream content by departments. It is an addition to giving access by matching owning_org_content_ids with users organisation_content_id, to ensure we do not block access for some departments.
Follow these steps if you are doing a Rails upgrade.