PP-3004 Switch to standard npm dep install pattern

- Copied pattern used in all our other Node.js dockerfiles using a symlink for node_modules

.dockerignore

@@ -12,9 +12,9 @@ Jenkinsfile
 CONTRIBUTING.md
 env.sh
 .snyk
-build-local.sh
+node_modules
+node_modules_local
 logs/**/*
-.sass-lint.yml
 .jshintrc
 .sass-lint.yml
 Dockerfile

Dockerfile

@@ -7,7 +7,12 @@ RUN apk update &&\
 ENV PORT 9000
 EXPOSE 9000
 
+ADD package.json /tmp/package.json
+RUN cd /tmp && npm install --production
+
 WORKDIR /app
 ADD . /app
 
+RUN ln -s /tmp/node_modules /app/node_modules
+
 CMD npm start

build-local.sh

@@ -1,6 +1,4 @@
 #!/bin/bash
-docker build --file docker/build_and_test.Dockerfile -t govukpay/frontend-build:local . &&\
-docker run --volume $(pwd):/app:rw govukpay/frontend-build:local &&\
-docker build -t govukpay/frontend:local . &&\
-npm rebuild &&\
- npm i
+
+npm install && npm run compile &&\
+docker build -t govukpay/frontend:local .

docker/build_and_test.sh

@@ -6,8 +6,8 @@ grep -rnw './test' -e 'it.only' && echo '' && echo 'ERROR: it.only() found in te
 grep -rnw './test' -e 'describe.only' && echo '' && echo 'ERROR: describe.only() found in tests, Exiting' && exit 1
 grep -rnw './test' -e 'context.only' && echo '' && echo 'ERROR: context.only() found in tests, Exiting' && exit 1
 
-mkdir -p /app &&\
-cp -a /tmp/node_modules /app/ &&\
+rm -rf node_modules &&\
+ln -s /tmp/node_modules /app/node_modules &&\
 npm run compile &&\
 npm test &&\
-npm prune --production
+rm -rf node_modules