Skip to content

Commit

Permalink
PP-5917: revert Node to 12.2
Browse files Browse the repository at this point in the history
* issue in async_hooks in the latest LTS version of node
* sentry relies on async_hooks
* downgrade until the patch is released for LTS node
  • Loading branch information
sfount committed Dec 4, 2019
1 parent 728cfb9 commit 356d699
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
12.13.1
12.2.0
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node@sha256:b556d8910b851c27c5c8922eeb55d94fe6dbaf878d24bf0c9a8c32ba21cd091a
FROM node@sha256:2ab3d9a1bac67c9b4202b774664adaa94d2f1e426d8d28e07bf8979df61c8694

### Needed to run appmetrics and pact-mock-service
COPY sgerrand.rsa.pub /etc/apk/keys/sgerrand.rsa.pub
Expand Down
4 changes: 2 additions & 2 deletions docker/build_and_test.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node@sha256:b556d8910b851c27c5c8922eeb55d94fe6dbaf878d24bf0c9a8c32ba21cd091a
FROM node@sha256:2ab3d9a1bac67c9b4202b774664adaa94d2f1e426d8d28e07bf8979df61c8694

### Needed to run appmetrics and pact-mock-service
COPY sgerrand.rsa.pub /etc/apk/keys/sgerrand.rsa.pub
Expand All @@ -12,4 +12,4 @@ ADD package-lock.json /tmp/package-lock.json
RUN cd /tmp && npm install
WORKDIR /app
ENV LD_LIBRARY_PATH /app/node_modules/appmetrics
CMD ./docker/build_and_test.sh
CMD ./docker/build_and_test.sh
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"license": "MIT",
"engines": {
"node": "12.13.1"
"node": "12.2.0"
},
"standard": {
"globals": [
Expand Down

0 comments on commit 356d699

Please sign in to comment.