Skip to content

Fix types being sent to template_email_files update endpoint and add cache invalidation to updates #5774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rparke wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Fix types being sent to template_email_files update endpoint and add cache invalidation to updates #5774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions app/models/template_email_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,9 @@ def update(self, template_id):
template_id=template_id,
template_email_file_id=self.id,
data={
"filename": self.filename,
"link_text": self.link_text,
"link_text": self.link_text if self.link_text else "",
"retention_period": self.retention_period,
"validate_users_email": self.validate_users_email,
"validate_users_email": bool(self.validate_users_email),
},
)

Expand Down
3 changes: 2 additions & 1 deletion app/notify_client/template_email_file_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from werkzeug.local import LocalProxy

from app import memo_resetters
from app.notify_client import NotifyAdminAPIClient
from app.notify_client import NotifyAdminAPIClient, cache


class TemplateEmailFileClient(NotifyAdminAPIClient):
Expand All @@ -29,6 +29,7 @@ def create_file(
}
return self.post(f"/service/{service_id}/templates/{template_id}/template_email_files", data=data)

@cache.delete_by_pattern("service-{service_id}-template-{template_id}*")
def update_file(
self,
template_email_file_id,
Expand Down