ITHC fix headers for admin #5763
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the headers X-Content-Type-Options: X-Content-Type-Options: nosniff Strict-Transport-Security: Strict-Transport-Security: max-age=31536000; includeSubDomains Cache-control: Cache-control: no-store / Pragma: no-cache X-Frame-Options: X-Frame-Options: DENY / X-Frame-Options: SAMEORIGIN X-Permitted-Cross-Domain-Policies: X-Permitted-Cross-Domain-Policies: none It removes X-Xss-Protection: 1; mode=block
whpearson
force-pushed
the
add_security_headers
branch
from
4dd0149 to
ea4abb4
Compare
Contributor
|
most things work as expected. I do get an error previewing newly created letter branding, but that could just be notifications-local having an issue. |
Contributor
Author
|
Okay, I'll work on that today. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the headers
X-Content-Type-Options: X-Content-Type-Options: nosniff
Strict-Transport-Security: Strict-Transport-Security: max-age=31536000; includeSubDomains
Cache-control: Cache-control: no-store / Pragma: no-cache
X-Frame-Options: X-Frame-Options: DENY / X-Frame-Options: SAMEORIGIN
X-Permitted-Cross-Domain-Policies: X-Permitted-Cross-Domain-Policies: none
It removes
X-Xss-Protection: 1; mode=block
I've checked it locally for email branding in safari, firefox and chome.