-
Notifications
You must be signed in to change notification settings - Fork 39
Update "Add a service", "confirm your service is unique" and "change service name" pages #5762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kr8n3r
wants to merge
5
commits into
main
Choose a base branch
from
update-name-your-service-guidance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+70
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e536c1 to
f04f9e0
Compare
f04f9e0 to
d94db40
Compare
e426ea1 to
52faa25
Compare
9eec9f6 to
2efb399
Compare
685f0f9 to
47c7386
Compare
6aa026e to
e14767c
Compare
This updates content based on the content document (see Trello ticket) and makes the following markup changes: - removes conditional content from bullet points - adds a visible legend styled as h2 to the `organisation_type` to bring the section into prominence - adds organisation_type form paramaters from python into the html code - adds a 'details' element with new content
'CreateNhsServiceForm' classes - Update the service name field label - Remove the form label from OrganisationTypeField class as we now control the legend text in the view.
Update tests that check for H1 text Remove the test that was testing conditional content in the bullet point examples, as they're no loneger present.
Update according to content doc - https://docs.google.com/document/d/1ZItE5zQzkkdraRHrRml6AXlIldXPfaO0ODS2VUYLMvI/edit?tab=t.0 Remove conditional content Update test and remove redundant ones
e14767c to
48601c1
Compare
tombye
approved these changes
Feb 3, 2026
Contributor
tombye
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good and the content matches that in the docs. Also thanks for making a change I asked for outside of this review (removing a h2 above some radios and using their legend instead) 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the guidance on the ‘Add a new service’ screen.
Explicitly tell users that the service name is for us (Notify), and not for recipients.
Update the guidance on the ‘Confirm your service is unique’ page.
Explicitly tell users that the service name is for us (Notify), and not for recipients.
Replace the old instructions.
Trello card
Trello card
Changes include:
Why
In order to encourage users to choose a good service name (one which doesn’t cause problems when they request to go live), we need to change the name-your-service guidance.
We need to update the content on the ‘Confirm your service is unique’ page so that it does not contradict the ‘Name your service’ page.
Visuals
Before
After