Skip to content

Speed up tests by generating less CSV data #5759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quis wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −4
Open

Speed up tests by generating less CSV data #5759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
accbed8
Don’t generate 100k rows of test data
quis Jan 23, 2026
d9077ba
Don’t generate 10k columns of test data
quis Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/app/main/views/test_send.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,7 +1054,7 @@ def test_upload_csv_file_limits_number_of_columns_displayed_when_error(
"app.main.views.send.s3download",
return_value=(
f"""
{"phone number," * 10_000}
{"phone number," * 678}
+447700900111
+447700900222
"""
Expand Down
11 changes: 8 additions & 3 deletions tests/app/main/views/uploads/test_upload_contact_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import uuid
from io import BytesIO
from unittest.mock import ANY
from unittest.mock import ANY, PropertyMock

import pytest
from flask import url_for
Expand Down Expand Up @@ -221,9 +221,14 @@ def test_upload_csv_file_shows_error_banner_for_too_many_rows(
mocker.patch("app.models.contact_list.s3upload", return_value=fake_uuid)
mocker.patch("app.models.contact_list.set_metadata_on_csv_upload")
mocker.patch(
"app.models.contact_list.s3download", return_value="\n".join(["phone number"] + (["07700900986"] * 100_001))
"app.models.contact_list.s3download", return_value="\n".join(["phone number"] + (["07700900986"] * 4_567))
)
mocker.patch("app.models.contact_list.get_csv_metadata", return_value={"original_file_name": "invalid.csv"})
mocker.patch(
"app.main.views.uploads.RecipientCSV.max_rows",
new_callable=PropertyMock,
return_value=1_234,
)

page = client_request.post(
"main.upload_contact_list",
Expand All @@ -233,7 +238,7 @@ def test_upload_csv_file_shows_error_banner_for_too_many_rows(
)

assert normalize_spaces(page.select_one(".banner-dangerous").text) == (
"Your file has too many rows Notify can store files up to 100,000 rows in size. Your file has 100,001 rows."
"Your file has too many rows Notify can store files up to 1,234 rows in size. Your file has 4,567 rows."
)
assert len(page.select("tbody tr")) == 50
assert normalize_spaces(page.select_one(".table-show-more-link").text) == "Only showing the first 50 rows"
Expand Down