Spreadsheet.from_file: use load_data from pyexcel_io instead of iget_array
#5690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…array it's unclear to what extent this is a private/public api, but it allows us to reuse a "reader" object across multiple calls, which for some plugins should be able to save a some setup cost while still allowing us to read the header row and data rows with different column_limit values also re-enable column_limit_from_header support for xlsx/xlsm
risicle
force-pushed
the
ris-spreadsheet-load-data-reuse-reader
branch
from
08b1b84 to
770848c
Compare
now using pyexcel-io directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear to what extent this is a private/public api, but it allows us to reuse a "reader" object across multiple calls, which for some plugins should be able to save a some setup cost while still allowing us to read the header row and data rows with different
column_limitvalues.Also re-enable
column_limit_from_headersupport for xlsx/xlsm.