Remove some unnecessary things #5041
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
remove-unnecessary
branch
from
3fb3a7a to
862c08c
Compare
andysellick
force-pushed
the
remove-unnecessary
branch
from
862c08c to
6990097
Compare
andysellick
force-pushed
the
remove-unnecessary
branch
from
6990097 to
d147865
Compare
andysellick
force-pushed
the
remove-unnecessary
branch
from
d147865 to
ff798ed
Compare
andysellick
force-pushed
the
remove-unnecessary
branch
from
ff798ed to
822d316
Compare
andysellick
force-pushed
the
remove-unnecessary
branch
from
822d316 to
d07a1fd
Compare
- most of our components seem to import individual_component_support by default (which itself imports govuk_frontend_support, which mainly imports govuk-frontend-settings and govuk-base) - these ones don't need it, it turns out - not sure if this makes a difference to anything, but it might fractionally improve the compilation time
- margin_bottom option is already demonstrated in a specific example, having it included in these extra examples seems unnecessary
andysellick
force-pushed
the
remove-unnecessary
branch
from
d07a1fd to
8fecf28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes some unnecessary
@importlines from component Sass, and some unneeded options in thebutton.ymlfile, see commits for details.Why
Spotted this while doing some unrelated work.
Visual Changes
None, hopefully.