Skip to content

Conversation

KludgeKML
Copy link
Contributor

  • We exclude rails, and most of the JS packages (especially govuk-frontend).

- We exclude rails, and most of the JS packages (especially
  govuk-frontend).

Co-authored-by: Leena Gupte <[email protected]>
Co-authored-by: Andy Sellick <[email protected]>
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4780 April 30, 2025 15:25 Inactive
@MartinJJones
Copy link
Contributor

MartinJJones commented Apr 30, 2025

Looks good, just a couple of thoughts/questions:

  • From looking at the developer docs, do we need to update name, from Continuous integration to CI in ci.yml?

In contrast, the ci.yml must have a name property called CI, as this is relied upon by our automated tooling.

"MUST only be applied where there is no manual deployment step"

@KludgeKML
Copy link
Contributor Author

@MartinJJones Interesting!

There certainly seems to be precedent for gems: https://github.com/alphagov/govuk-dependabot-merger/blob/main/config/repos_opted_in.yml#L22C3-L22C19 ...gds-api-adapters among others are included in the list. I think I'd argue it's safe because in this case they are themselves part of apps that are manually deployed (so if government frontend auto-deploys with a broken version of this gem, although the downstream question of "which dependency in publishing components caused this" is muddied, the question of "which dependency in government-frontend cause this is clear" (ie it's publishing components). I will seek guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants