govukapp-2592: background splash screen #573
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not already showing. Don't try to restore modals which were dismissed on privacy presentation. Not a requirement and increases complexity.
Only show privacy screen on app timeout if biometrics are enabled.
joshdubey
force-pushed
the
feature/govukapp-2592-background-splash-screen
branch
from
c310ff1 to
3fd4239
Compare
|
joshdubey
changed the title
joshdubey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Present a privacy screen when the app is backgrounded or the idle timer fires.
This is the same implementation as original PR, except that the privacy screen is only shown if the user is logged in. This is to allow biometric authentication to occur during login process if user is using a password manager for their one login account info.
Also makes sure we only attempt to present privacy screen if one is not already showing.
Explicitly shows privacy screen on idle timer, and hides on peri-auth completion, rather than relying on scene delegate.