Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump del from 6.1.1 to 7.0.0 #2968

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 7, 2022

Bumps del from 6.1.1 to 7.0.0.

Release notes

Sourced from del's releases.

v7.0.0

Breaking

  • Require Node.js 14 (#143) 106d7d8
  • This package is now pure ESM. Please read this.
  • Moved from a default export to named exports:
    • require('del')import {deleteAsync} from 'del'
    • require('del').syncimport {deleteSync} from 'del'

sindresorhus/del@v6.1.1...v7.0.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Nov 7, 2022
@dependabot dependabot bot requested a review from a team November 7, 2022 11:14
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2968 November 7, 2022 11:14 Inactive
@colinrotherham
Copy link
Contributor

colinrotherham commented Nov 7, 2022

Some of our (potential) package updates like del@7 and slash@4 have dropped CommonJS support

Like our component JavaScript we could move our tooling to ESM *.mjs

Or a quick fix would be to use dynamic import() which works for both CommonJS and ESM

Before (CommonJS)

./tasks/clean.js

const del = require('del')

function clean () {
  return del(paths())
}

After (CommonJS)

./tasks/clean.js

async function clean () {
  const { deleteAsync } = await import('del')
  return deleteAsync(paths())
}

After (ESM)

./tasks/clean.mjs

import { deleteAsync } from 'del'

function clean () {
  return deleteAsync(paths())
}

@colinrotherham
Copy link
Contributor

Workaround for ESM only del@7 demonstrated in #2984

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/del-7.0.0 branch from 4ffc32b to 1ee234e Compare November 9, 2022 10:56
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2968 November 9, 2022 10:56 Inactive
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/del-7.0.0 branch from 1ee234e to 6e1ae9e Compare November 17, 2022 14:39
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2968 November 17, 2022 14:40 Inactive
Bumps [del](https://github.com/sindresorhus/del) from 6.1.1 to 7.0.0.
- [Release notes](https://github.com/sindresorhus/del/releases)
- [Commits](sindresorhus/del@v6.1.1...v7.0.0)

---
updated-dependencies:
- dependency-name: del
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/del-7.0.0 branch from 6e1ae9e to ac7e818 Compare November 18, 2022 10:44
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2968 November 18, 2022 10:44 Inactive
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 29, 2022

Looks like del is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Nov 29, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/del-7.0.0 branch November 29, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants